search

jreijn / spring-comparing-template-engines

Demo project to show different Java templating engines in combination with Spring MVC
Apache License 2.0
422 stars 116 forks source link

Major upgrade of all available components #38

Closed Vest closed 5 years ago

Vest commented 5 years ago

My thoughts is that this repository might become dead, since it is difficult to put all components altogether inside the same container. E.g. rythm is already deprecated and not used here anymore.

Vest commented 5 years ago

@jreijn if possible, can you please test my PR, I hope you like it :)

There are other PRs that should be reviewed, probably.

Vest commented 5 years ago

oh! I forgot to add - now we have favicon.ico :)

jreijn commented 5 years ago

Wow that's great! Really awesome work. I started myself but you already finished it. 👏

Vest commented 5 years ago

I hope you tested it. We have a difficulty with scalate. I cannot upgrade it to scala 2.12 and use it with Gatling.

jreijn commented 5 years ago

I have not tested it yet, but will do during the weekend.

Op vr 8 feb. 2019 om 16:55 schreef Vest notifications@github.com

I hope you tested it. We have a difficulty with scalate. I cannot upgrade it to scala 2.12 and use it with Gatling.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/jreijn/spring-comparing-template-engines/pull/38#issuecomment-461849239, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeKHmKd4iysMgne8CPnpNnQt8_feMBQks5vLZ3qgaJpZM4anWHR .

-- Verzonden via Gmail Mobile

Vest commented 5 years ago

Ok. No need to hurry. It is enough to use: mvn spring-boot:run

But there is a but with this project. Scalate uses scala 2.11 now. But unfortunately when I switched it to 2.12 or alpha 2.13, the classpath error occurs. Scala tries to find dependencies in a wrong path. This is because they changed a single line in the manifest. The issue looks so weird, that after two days I was not able to resolve it. The major drawback is that Gatling uses 2.12 or later. I will try later to play with gradle, maybe it will work better.

jreijn commented 5 years ago

Yes or we can leave out Gatling. It was just an experiment.

Op za 9 feb. 2019 om 09:28 schreef Vest notifications@github.com

Ok. No need to hurry. It is enough to use: mvn spring-boot:run

But there is a but with this project. Scalate uses scala 2.11 now. But unfortunately when I switched it to 2.12 or alpha 2.13, the classpath error occurs. Scala tries to find dependencies in a wrong path. This is because they changed a single line in the manifest. The issue looks so weird, that after two days I was not able to resolve it. The major drawback is that Gatling uses 2.12 or later. I will try later to play with gradle, maybe it will work better.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/jreijn/spring-comparing-template-engines/pull/38#issuecomment-462025215, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeKHp9gt0lEWmcatzXuPzHKH-j1BE1Bks5vLoaogaJpZM4anWHR .

-- Verzonden via Gmail Mobile