jreklund / php4dvd

php4dvd is an open source php/mysql powered movie database. Catalog your video collection with ease. Automatic update of information and images.
GNU General Public License v3.0
83 stars 43 forks source link

New field: IMDb Number of Votes #29

Closed kkayacan closed 6 years ago

kkayacan commented 6 years ago

I like sorting movies by number of votes on IMDb so a new sortable field would be great. I believe imdphp library already supports this data. If you advise where to look, I can try to add this.

  /**
   * Return number of votes for this movie
   * @method votes
   * @return int
   * @see IMDB page / (TitlePage)
   */
  public function votes() {
    if ($this->main_votes == -1) $this->rate_vote();
    return $this->main_votes;
  }
jreklund commented 6 years ago

I think this is everywhere. Should take a half hour if you know the code. xD

/install/sql/update-3.7.sql New file needed, votes added after rating. Don't know how many votes there are, but an int 8 unsigned should be enough. /config/version.default.inc.php Db version into 3.7 and normal version bump for installation script to be able to run /includes/export.inc.php Export the new value (votes) /includes/movie.search.inc.php Adding it as a new $sortoptions **/lang/* Translate the new "votes asc" and "votes desc" string. /lib/db/Movie.class.php Adding it to fill() /template/default/movies/update.html Update form, also add it after rating. The name="" should be votes, and that should be the same everywhere. There are an option to validate for only numbers, don't know it by heart. /template/default/movies/movie.html** Displaying the value in the movie / tv-show page

kkayacan commented 6 years ago

Thanks. I'll try at weekend.

kkayacan commented 6 years ago

Changes work for me, thank you very much. Shall I create a pull request (never done that before) or will you do it yourself at next release?

jreklund commented 6 years ago

If you wan't credit for it make a pull request and I will look over your code. Or I will do it myself after I'm finished with another wanted feature.