search

jreleaser / jreleaser

:rocket: Release projects quickly and easily with JReleaser
https://jreleaser.org
Apache License 2.0
944 stars 109 forks source link

[chocolatey] Native Image doesn't need Install-BinFile #740

Closed aalmiray closed 2 years ago

aalmiray commented 2 years ago

Discussed in https://github.com/jreleaser/jreleaser/discussions/739

Originally posted by **mthmulders** February 3, 2022 I've recently submitted [a package](https://community.chocolatey.org/packages/mcs) (a native image) for review to Chocolatey. Today, one of the reviewers over there mentioned: > Since the archive is extracted to a folder inside `$tool`s, there should not be a need to manually create a shim with `Install-BinFile`, as the shim would be created automatically. I think this means we could remove the last line of the [chocolateyinstall.ps1.tpl](https://github.com/jreleaser/jreleaser/blob/main/core/jreleaser-templates/src/main/resources/META-INF/jreleaser/templates/native-image/chocolatey/tools/chocolateyinstall.ps1.tpl) for native-images?

It also should mean the uninstall script is not needed.

Originally posted by @TheCakeIsNaOH in https://github.com/jreleaser/jreleaser/discussions/739#discussioncomment-2104816

aalmiray commented 2 years ago

Affects NATIVE_IMAGE and BINARY templates