search

jreleaser / release-action

:octocat: GitHub Action for JReleaser
https://jreleaser.org
Apache License 2.0
34 stars 3 forks source link

setup-java input of false is ignored #7

Closed dmurat closed 2 years ago

dmurat commented 2 years ago

I'm trying to use non-default Java runtime with release-action, but without success. I tried to configure setup-java with both false and "false", but release-action always uses the default Zulu 17 runtime.

I might be wrong, but it looks like the problem is in action.yml at line 35:

if: ${{ inputs.setup-java }} == 'true' || ${{ inputs.setup-java }} == true

I believe that the second condition will be truthy if anything non-empty is configured for setup-java

aalmiray commented 2 years ago

Release 2.1.2 has the fix, as well as v2 branch.