search

jremmen / vim-ripgrep

Use RipGrep in Vim and display results in a quickfix list
MIT License
541 stars 99 forks source link

Fix E1208 started showing up in Vim v8.2.3149 #56

Closed tacahiroy closed 2 years ago

tacahiroy commented 3 years ago

-complete is not needed since :RgRoot takes no arguments. This fix prevents the error E1208 at Vim starts up with Vim v8.2.3149 or newer.

$ vim --version | head -2
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jul 12 2021 09:32:07)
Included patches: 1-3154

$ vim
Error detected while processing /home/xxx/.vim/pack/minpac/start/vim-ripgrep/plugin/vim-ripgrep.vim:
line  149: E1208: -complete used without -nargsPress ENTER or type command to continue
deybhayden commented 3 years ago

Tested locally and works for me as well - also on v8.2.3149 or newer though.

gonzaloserrano commented 3 years ago

Worked for me too.

zyegfryed commented 3 years ago

Fixing #57

brandonpittman commented 3 years ago

This works! LTGM.

johnnymo87 commented 3 years ago

I tested this commit locally and it works for me as well. I'm using vim 8.2.3325. More version details:

$ vim --version | head -n 4
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Aug 10 2021 19:39:20)
macOS version - arm64
Included patches: 1-3325
Compiled by Homebrew
tsullivan commented 3 years ago

Works for me using nvim:

nvim --version | head -n 4
NVIM v0.6.0-dev
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9=. -fstack-protector-strong -Wformat -Werror=format-security -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/build/config -I/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/src -I/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/.deps/usr/include -I/usr/include -I/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/build/src/nvim/auto -I/build/neovim-0bOHCD/neovim-0.5.0+ubuntu2+git202108111755-7d2233fad-d569569c9/build/include
AlexisFinn commented 2 years ago

Any chance of this getting merged ? Since the project hasn't been updated in 3 years...