jremmen / vim-ripgrep

Use RipGrep in Vim and display results in a quickfix list
MIT License
541 stars 99 forks source link

correct nargs errors for vim 8.2.3150+ #58

Closed lamchau closed 2 years ago

lamchau commented 3 years ago

https://github.com/vim/vim/pull/8544 introduced a change that displays an error when nargs is not defined and/or defined incorrectly. As a user, this will display an error message each time upon starting up. The error shows up as

Error detected while processing ~/.vim/plugged/vim-ripgrep/plugin/vim-ripgrep.vim:
line  149: E1208: -complete used without -nargs
Press ENTER or type command to continue

This fix to add -nargs=? to each of the commands.

Fixes #57

a5ob7r commented 3 years ago

For the same or similar purpose as #56?

cmorgannorris commented 3 years ago

Worked for me. 👍🏼

Anthirian commented 3 years ago

I can confirm this fixed #57 on my end as well.

jonathanpglick commented 3 years ago

Can we get this merged? Or is this plugin repo abandoned?

ripxorip commented 3 years ago

I can too confirm that this patch works. Would like this merged if possible.

sirbrillig commented 2 years ago

🙏

morngrar commented 2 years ago

:pray:

sorliem commented 2 years ago

Just ran into this also :pray:

johnhayesio commented 2 years ago

Same here. Experiencing the same issue now.

hinatades commented 2 years ago

This worked fine! Please merge into master 🙏

alichtman commented 2 years ago

Only the change on line 149 is necessary (I think), but can confirm this fixed the issue for me.

AaronM04 commented 2 years ago

The last time the project maintainer merged a PR to master was 3 years ago, so I would call this repo abandoned.

Is there an active fork we can all go to instead?

vNNi commented 2 years ago

While i wait for the maintainer, i forked and made the fix here: https://github.com/vNNi/vim-ripgrep.. but i really don't want to use them for a long time.

awseward commented 2 years ago

@vNNi For what it's worth, you could also just use 68ec5ba64d23212c5b3ae56599fb758254a2f435 from this PR itself.

That's what I've pointed my vim-plug config at in the meantime, at least. 😅

ghost commented 2 years ago

@AaronM04 I created a fork and implemented this PR along with some misc docs improvements. Any and all contributions are welcome.
https://github.com/mi544/vim-ripgrep

cmorgannorris commented 2 years ago

Was this resolved?

nixpulvis commented 2 years ago

@cmorgannorris yes, see #56.