Make sure all function calls to njit'd functions which have default arguments have all of their arguments spelled out

jrenaud90 / TidalPy

Software suite to perform solid-body tidal dissipation calculations for rocky and icy worlds

Other

15 stars 3 forks source link

Make sure all function calls to njit'd functions which have default arguments have all of their arguments spelled out #30

Closed jrenaud90 closed 6 months ago

jrenaud90 commented 2 years ago

There is a problem with the current version of numba (see bug report here) where if a function has default args but they are not used in a function call then the call is significantly slower.

The current work around is to provide all default args whenever possible.

jrenaud90 commented 6 months ago

While this issue is still a problem, it soon won't be thanks to the transition to Cython starting with PR #46.