search

jrendel / SwiftKeychainWrapper

A simple wrapper for the iOS Keychain to allow you to use it in a similar fashion to User Defaults. Written in Swift.
MIT License
1.59k stars 340 forks source link

Carthage support #14

Open kimsanghyok opened 9 years ago

kimsanghyok commented 9 years ago

This project support cocoapod and it's good. And then why not adding carthage support?

albertkim commented 9 years ago

Not on the roadmap yet?

jrendel commented 9 years ago

Hey guys, I'm not opposed to putting this in, I just haven't had time. I don't have any experience with carthage at the moment. And yes the current project supports cocoa pods, but its not part of the official cocoa pods repo yet, so you have to use it as a private repo. Thats on the list of things to do as well.

jrendel commented 9 years ago

I've updated to v1.0.10 on master now which includes a pull request that added Carthage support. I do not use Carthage myself, so if anyone wants to test it out and let me know if it works, that would be much appreciated and then we can close this issue. Else I'll try and find time to look into Carthage more and see how to test it myself.

lexrus commented 8 years ago

@jrendel Thank you for the update. I did test with the following Cartfile:

github "jrendel/SwiftKeychainWrapper"

And run carthage update in the same project folder. After a couple seconds, the SwiftKeychainWrapper.framework built under ./Carthage/Build/iOS/. Everything works fine apart from the warnings:

/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:129:16: warning: immutable value 'retrievedString' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:192:13: warning: variable 'testInt' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:193:13: warning: variable 'myTestObject' was never mutated; consider changing to 'let' constant
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:208:16: warning: immutable value 'retrievedObject' was never used; consider replacing with '_' or removing it
/Users/lex/git/VPNOn/Carthage/Checkouts/SwiftKeychainWrapper/SwiftKeychainWrapperTests/KeychainWrapperTests.swift:248:16: warning: immutable value 'retrievedData' was never used; consider replacing with '_' or removing it

I guess you should upgrade to Xcode 7.1 and Swift 2.1.

In addition, a simple instruction in README talking about how to build this lib with Carthage would be nice. Take an example: https://github.com/alamofire/alamofire

kkontus commented 8 years ago

Any indications when this warnings might be fixed?