search

jrendel / SwiftKeychainWrapper

A simple wrapper for the iOS Keychain to allow you to use it in a similar fashion to User Defaults. Written in Swift.
MIT License
1.59k stars 339 forks source link

Add support for Swift Package Manager #144

Closed adincebic closed 3 years ago

adincebic commented 4 years ago

I have added package.swift file to support SPM. Note that I did not specify minimum platform version as it is iOS 8 by default.

mateuszjablonski commented 4 years ago

@jrendel is there any possibility this will be merged soon? My project depends on it.

adincebic commented 4 years ago

You can use my fork until this gets merged.

Sent from my iPhone

On 31 Dec 2019, at 13:28, Mateusz Jabłoński notifications@github.com wrote:

 @jrendel is there any possibility this will be merged soon? My project depends on it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jimisaacs commented 4 years ago

@jrendel please merge this

thejeff77 commented 4 years ago

@adincebic - As this impacts all users, updating the README would go along nicely with this PR, and will likely increase the chances of @jrendel merging this sooner.

mattmaddux commented 4 years ago

I added a new PR (#149) that includes updates to the README (as well as a tests target). At first I didn't see the TWO other PRs adding SPM and removed mine once I did. But decided to reopen after reading the comment above from @thejeff77.

jrendel commented 3 years ago

Sorry I haven't kept up with the repo guys, but I've now merged in one of the other Swift Package Manager PRs, so I'm going to close this one.