jrendel / SwiftKeychainWrapper

A simple wrapper for the iOS Keychain to allow you to use it in a similar fashion to User Defaults. Written in Swift.
MIT License
1.59k stars 340 forks source link

Add KeychainItemOptions struct and supporting enums. Support options in KeychainWrapper public API. #39

Closed jamesmblair closed 8 years ago

jamesmblair commented 8 years ago

This is a sample implementation of the method parameter options design I had in mind for SecClass and SecAttrAccessible. The options type could be could be extended further for other attributes. I also added method overloads in the KeychainWrapper class to support the options parameter. What are your thoughts on an implementation like this?

jrendel commented 8 years ago

Awesome work James! This looks great. Using the struct for the options values was great call, helps keep the method signatures down. I'm going to merge this in and continue the discussion here https://github.com/jrendel/SwiftKeychainWrapper/issues/38.