search

jrendel / SwiftKeychainWrapper

A simple wrapper for the iOS Keychain to allow you to use it in a similar fashion to User Defaults. Written in Swift.
MIT License
1.59k stars 339 forks source link

Enable macOS usage of Pod #55

Closed duncan closed 7 years ago

duncan commented 8 years ago

Small changes to allow for pod inclusion in macOS projects. Address issue #43.

Ideally, there’d be a Mac target for both the framework and tests. I did hack one in locally to check things out, but it’s currently messy enough with regards to naming etc that I’m going to hold off on sending it up.

jrendel commented 8 years ago

I haven't actually tested the wrapper on mac OS and I'm pretty sure it has additional changes that are needed to work properly. Did you run into any other changes you had to make to get it running on mac OS?

I'm currently working on the Swift 3.0 changes and then may consider adding mac OS support.

duncan commented 8 years ago

No other changes, but I didn't test the 2.2 stuff too far past the unit tests. I've been using the Swift 3.0 changes from @jordanekay in my work and things have been working fine on macOS. I'll pull your new branch and give it a try there.

jrendel commented 7 years ago

There are other changes needed as keychain behaves differently in macOS. Closing this as there is already an issue open to add macOS support: https://github.com/jrendel/SwiftKeychainWrapper/issues/43