Slightly wrong Dokumentation

jrester / tesla_powerwall

Python API for Tesla Powerwall

MIT License

73 stars 24 forks source link

Slightly wrong Dokumentation #28

Closed kl1947 closed 3 years ago

kl1947 commented 3 years ago

First: Thank you, jrester, for this module!

In the doku part "Authentication": powerwall.login("", "") powerwall.login_as(User.INSTALLER, "", "") should read: powerwall.login("","" ) powerwall.login_as(User.INSTALLER, "", "")

Another hint, NO ISSUE: powerwall = Powerwall("") Powerwall Firmware 20.49.x worked with a locally resolvable NAME as ip, Firmware 21.20.6 requires the ip address. So the Doku is correct.

jrester commented 3 years ago

Hey there,

I am sorry but I can't see any difference between the two. Thanks for reporting the part about the ip and hostname. I will add it to the doumentation!

jrester commented 3 years ago

Closing this because of inactivity