Natural Gas introduction

N3rdP1um23 commented 1 year ago

As mentioned in https://github.com/jrfernandes/ontario_energy_board/issues/13, the following PR includes the additional of Natural Gas prices!! 🎊

Since the last main version

There only one major breaking change
- Users will have to select their electricity companies again as the entity id has changed to include the energy sector
There's only a single potential breaking change
- Some of the newer keys (https://github.com/jrfernandes/ontario_energy_board/commit/0bf7fa7a7d2ed7b1e95358ffedcc954a54d6a152) have been changed slightly to follow the definitions from OEB - which may require users to modify existing calls for attritional attributes

The flow still remains the same when selecting a Natural Gas option. When you go to add a new OEB integration, all energy (electricity & natural gas) companies/options will be listed. The company names (and furthermore the entity id) has changed slightly

Old: COMPANY (CLASS)
New: COMPANY (CLASS) [SECTOR]

Other than that, I just need to clean up some of the formulas that I've received from OEB to calculate the potential monthly bill. Once that's done, I'll share an update as well!

If you have any questions/comments/concerns, feel free to let me know! 😃

PS Included in this update, I've also taken care of the following issue (https://github.com/jrfernandes/ontario_energy_board/issues/21) where a deprecated function call was being used.

N3rdP1um23 commented 1 year ago

Hey! Just wanted to follow up and see if there was any update on this PR? 🙂 Let me know if you need anything!

jrfernandes commented 1 year ago

Thank you for your contribution, @N3rdP1um23. I'll try my best to do a code review during the weekend.

N3rdP1um23 commented 1 year ago

Hey @jrfernandes! My pleasure! Happy to contribute and future the extension for HA. Oh no worries at all and take your time 🙂

jrfernandes commented 1 year ago

@N3rdP1um23 - There are some merge conflicts to be solved. Also, I've added black verification for consistent styling. You might have to update part of the code here for tests to pass (once main is merged here).

N3rdP1um23 commented 1 year ago

@jrfernandes Hey! Thanks for the update and enhancements to the repo. I've just gone through and have resolved the merge conflicts, upgraded using Black (and also formatted this PR), as well as resolving any lint issues. We should be good to go now :)

Let me know if you need anything else!

N3rdP1um23 commented 10 months ago

@jrfernandes Hey! Just wanted to follow up and see if there was anything else you needed in order to move this along :) No rush!

N3rdP1um23 commented 9 months ago

Just bumped up the all the minimum dependency versions to the latest version.

Digital-Ark commented 9 months ago

In case this helps anyone, this is how I'm reading my natural gas meter with a digital compass sensor.

I am eagerly awaiting this update that scrapes the OEB gas rates.

https://community.home-assistant.io/t/attempting-to-read-an-elster-acm-250-dumb-gas-meter-with-a-qmc5883l/600899

nromyn commented 3 months ago

Bumping @jrfernandes i would really appreciate this capability.

N3rdP1um23 commented 2 months ago

@jrfernandes Haha completely understand and I would also like to apologize. I've been making a few changes as well behind the scenes and haven't pushed just yet. Some of the changes will include some refactoring which I'll try and expedite to get done today or before the weekend!!

Thanks again and looking forward to building this project further! 😃

Edit: Once the last remaining changes are complete, I'll open up another PR for ya!

jrfernandes commented 2 months ago

That's great to hear. I appreciate the help.

Thank you.

jrfernandes / ontario_energy_board

Natural Gas introduction #22