jrfoell / campfire-libpurple

A Campfire protocol plugin for libpurple (Pidgin)
48 stars 16 forks source link

make failing - error: too many arguments to function ‘campfire_message_free’ #22

Closed pswartout closed 11 years ago

pswartout commented 11 years ago

I'm having issues building on both 32bit Ubuntu 12.04 & 64bit Mint Linux 14. Here's the output from sudo make command:

CC campfire.o CC message.o message.c: In function ‘campfire_message_handler’: message.c:512:3: error: too many arguments to function ‘campfire_message_free’ In file included from message.h:5:0, from message.c:4: http.h:66:6: note: declared here make: *\ [message.o] Error 1

I'm not too sure if I'm missing anything.

webframp commented 11 years ago

I get the same, this at least allowed me to compile it

diff --git a/http.h b/http.h
index 0ad234c..bfc0ced 100644
--- a/http.h
+++ b/http.h
@@ -63,7 +63,7 @@ void campfire_http_request(CampfireSslTransaction * xaction, gchar * uri,
 void campfire_queue_xaction(CampfireConn * campfire,
                CampfireSslTransaction * xaction,
                PurpleInputCondition cond);
-void campfire_message_free(gpointer data);
+void campfire_message_free(gpointer data, gpointer user_data);
 void campfire_xaction_free(CampfireSslTransaction *xaction);

 #endif /* not HTTP_H */
jfoell commented 11 years ago

Thanks for the report and the fix. It was my fault. I made some changes recently so we can build on windows, but I forgot to update the proto too.

pswartout commented 11 years ago

Works great now. Thanks