jrfoell / campfire-libpurple

A Campfire protocol plugin for libpurple (Pidgin)
48 stars 16 forks source link

Allow email addresses as 37signals account names. #4

Closed logic closed 12 years ago

logic commented 12 years ago

Had a bit of trouble getting connected, as my 37signals username is actually my email address (and I believe that's the direction they're going these days). This gets me as far as being able to pull a room list (I'm still crashing upon joining a room, which I'll hopefully have a patch for shortly).

jrfoell commented 12 years ago

The username field is actually only used for display purposes in the libpurple "Manage Accounts" window. It is not used for authentication or communication with Campfire. You can put whatever you want in there. The API Token is what's used for auth & comm.

jfoell commented 12 years ago

The hostname is parsed from the 'username' variable which pidgin squishes together like: Username@Hostname I believe logic is trying to fix hostname parsing when the username is something like: logic@37signals.com because the resulting 'username' that pidgin creates would be: logic@37signals.com@someplace.com which would then assign the wrong string to conn->hostname. Maybe it would look like this: 37signals.com@someplace.com which wouldn't resolve very well. Can anyone agree with me? If this is the case, then we should pull this change.

Jake

jfoell commented 12 years ago

BTW, I don't see where _displayname is being used. But if we pull logic's code, the display name would be the entire Username@Hostname mash up. Is this good or bad? I don't know.

jfoell commented 12 years ago

No one responded so I merged it. @logic, thanks for your change.