jrfonseca / drmingw

Postmortem debugging tools for MinGW.
GNU Lesser General Public License v2.1
273 stars 53 forks source link

Memory leaks in dwarf_pe.cpp #27

Closed ssbssa closed 8 years ago

ssbssa commented 8 years ago

UnmapViewOfFile() is needed in label no_intf and dwarf_pe_finish(). And intfc needs to be freed in dwarf_pe_finish() as well (like _free(dbg->de_objfile);).

jrfonseca commented 8 years ago

Thanks, fixed.

BTW, your https://github.com/ssbssa/heob project looks quite interesting. You might find some of the code https://github.com/apitrace/apitrace/tree/master/inject useful, as it has lots of workarounds for problems I found over the years. That said, I think that IAT patching is too brittle, and one of these days I'm going to scratch that code and use mhook.

ssbssa commented 8 years ago

Thanks for the links, mhook looks really interesting.