jrfonseca / drmingw

Postmortem debugging tools for MinGW.
GNU Lesser General Public License v2.1
273 stars 53 forks source link

Correctly handle Unicode file names in ExcHndl, add tests #75

Closed Robyt3 closed 1 year ago

Robyt3 commented 1 year ago

See commit messages below.

Closes #74.

codecov-commenter commented 1 year ago

Codecov Report

Merging #75 (f5a7978) into master (52c36c7) will decrease coverage by 2.18%. The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   50.66%   48.48%   -2.19%     
==========================================
  Files          15       15              
  Lines        1954     1941      -13     
  Branches      742      740       -2     
==========================================
- Hits          990      941      -49     
- Misses        743      770      +27     
- Partials      221      230       +9     
Impacted Files Coverage Δ
src/exchndl/exchndl.cpp 72.44% <58.33%> (-2.14%) :arrow_down:
src/common/log.cpp 58.00% <0.00%> (-6.04%) :arrow_down:
src/mgwhelp/mgwhelp.cpp 61.01% <0.00%> (-3.52%) :arrow_down:
src/common/debugger.cpp 42.94% <0.00%> (-2.85%) :arrow_down:
src/mgwhelp/dwarf_pe.cpp 83.33% <0.00%> (-1.63%) :arrow_down:
src/catchsegv/catchsegv.cpp 44.97% <0.00%> (-0.92%) :arrow_down:
src/mgwhelp/dwarf_find.cpp 48.17% <0.00%> (-0.61%) :arrow_down:
src/common/symbols.cpp 73.91% <0.00%> (-0.56%) :arrow_down:
src/addr2line/addr2line.cpp 50.98% <0.00%> (-0.48%) :arrow_down:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jrfonseca commented 1 year ago

Looks great. Thanks for doing this!