search

jrgifford / delayed_paperclip

Process your Paperclip attachments in the background with delayed_job or Resque.
http://www.jstorimer.com/ruby/2010/01/30/delayed-paperclip.html
MIT License
402 stars 155 forks source link

Test on new Rubies #163

Closed morgoth closed 8 years ago

ScotterC commented 8 years ago

@morgoth awesome thanks! Looks like 2.3 is having some issues on travis. Did it work locally?

morgoth commented 8 years ago

@ScotterC Locally 4 tests are failing because of calling private method. I thought I'll work on fix, but I'm not sure why it tries to install json gem in version 1.8.1 on Travis (and fails). Locally it installs 1.8.3 and bundle goes fine. Only difference I can see is that locally I have rubygems 2.5.2 and on travis it's 2.5.1, but not sure if this is the case.

morgoth commented 8 years ago

I just noticed that there is a similar PR https://github.com/jrgifford/delayed_paperclip/pull/160 and those 4 test failures is also what I get locally.

morgoth commented 8 years ago

@ScotterC I fixed it - gemfile.lock should not be checked in to repo https://github.com/thoughtbot/appraisal#version-control

Travis is green now.

What do you think about replacing redis dependency with fakeredis gem in specs?

ScotterC commented 8 years ago

@morgoth thanks!

definitely a fan of replacing the redis dependency to make testing easier