search

jrgifford / delayed_paperclip

Process your Paperclip attachments in the background with delayed_job or Resque.
http://www.jstorimer.com/ruby/2010/01/30/delayed-paperclip.html
MIT License
402 stars 155 forks source link

Refactor away deprecation warning for Rails 4 #29

Closed onomojo closed 11 years ago

onomojo commented 11 years ago

This just removes a deprecation warning when used in Rails 4.

jrgifford commented 11 years ago

I'm not sure what is causing the rbx failures.

onomojo commented 11 years ago

Strange. Tests are passing fine for me:

Running tests:

..................................................

Finished tests in 6.601728s, 7.5738 tests/s, 14.2387 assertions/s.

50 tests, 94 assertions, 0 failures, 0 errors, 0 skips

Running tests:

..................................................

Finished tests in 3.506537s, 14.2591 tests/s, 26.8071 assertions/s.

50 tests, 94 assertions, 0 failures, 0 errors, 0 skips

Running tests:

..................................................

Finished tests in 8.801357s, 5.6809 tests/s, 10.6802 assertions/s.

50 tests, 94 assertions, 0 failures, 0 errors, 0 skips

jrgifford commented 11 years ago

It's weird. All of the tests do that. - https://travis-ci.org/jrgifford/delayed_paperclip/jobs/7415116#L128

onomojo commented 11 years ago

Hard to say, I can't get that version of rubinius to build locally on osx to try to debug it.

jrgifford commented 11 years ago

right, I can't get it locally on Linux either. Tempted to drop that version of rbx entirely.

jrgifford commented 11 years ago

thank you!