jridgewell / Unlock

Unlock multiple Core Storage encrypted volumes at boot.
MIT License
198 stars 34 forks source link

Proper location for the binary #18

Closed cmsj closed 8 years ago

cmsj commented 8 years ago

It seems to be fairly unconventional to store the unlock binary in /Library/LaunchDaemons/. Given that homebrew sets crazy permissions on many /usr/local/ directories, and all of /System and /sbin are locked down by SIP, perhaps /Library/PrivilegedHelperTools/ would be a reasonable place to put the binary?

jridgewell commented 8 years ago

Given that homebrew sets crazy permissions on many /usr/local/ directories

We run as root during install, so that shouldn't be an issue. Want to open a PR?

tjluoma commented 8 years ago

Installers that write to /usr/local/bin/ work fine with Homebrew as long as it doesn't change ownership or permissions of that directory.

On Jan 27, 2016, at 3:48 PM, Justin Ridgewell notifications@github.com wrote:

Given that homebrew sets crazy permissions on many /usr/local/ directories

We run as root during install, so that shouldn't be an issue. Want to open a PR?

— Reply to this email directly or view it on GitHub.

cmsj commented 8 years ago

To be clear, I'm not saying that homebrew's permissions make it tricky to install in /usr/local, I'm saying that they make it inappropriate to install anything in there which will be run as root, on boot :)