Hoist Static Attrs

[jridgewell]

Following the best practices of iDOM, we should hoist our statics array as high as we can.

• For purely constant Static attributes (no key, or a literal key), we hoist the statics array to the Program node.
• When a variable key is defined, we hoist the Statics and replace the key's value with undefined in the array.
  • Once the "JSX" iDOM calls are run, we will assign the value of the key to the proper index of the array
• When we wrap a JSX element, we hoist the Statics to the scope of the eager attributes.

Implemented as an option for now, until I'm confident we've found the edge cases.

[jamiebuilds]

Should cases like:

function test(props) {
  props.key = 1;
  _statics31[3] = props.key;
  return elementVoid("div", props.key, _statics31);
}

Be resetting the value afterwards to avoid memory leaks?

function test(props) {
  props.key = 1;
  _statics31[3] = props.key;
  var _result = elementVoid("div", props.key, _statics31);
  _statics31[3] = null;
  return _result;
}

[jridgewell]

We could, but these should be simple strings (or numbers, but really just strings).

[jamiebuilds]

What about event handlers?

[jridgewell]

The _statics31[3] = key is only for the key attribute, objects (and functions) won't work properly with the keyMap inside iDOM.

[jamiebuilds]

Ooh I see.

[jridgewell]

Good to go?

[jamiebuilds]

Yeah, looks good.