search

jrief / django-admin-sortable2

Generic drag-and-drop ordering for objects in the Django admin interface
https://django-admin-sortable2.readthedocs.io/en/latest/
Other
753 stars 179 forks source link

1.0 prep #272

Closed marksweb closed 3 years ago

marksweb commented 3 years ago

Preparation for 1.0

jrief commented 3 years ago

@marksweb Thanks for your pull request. One thing to note is, that my editor uses .editorconfig and there max_line length = 119 as proposed by the Django style guide.

Until a few minutes ago, there was a typo in that file though 🤔.

marksweb commented 3 years ago

Thanks for the info @jrief

I've always used 80. I'll have to check if there's a pycharm plugin to read those config files. I'll revert to longer lines & then it might be ready.

jrief commented 3 years ago

Yes, it's bundled as plugin into PyCharm and I use that all the time. That's quite important where I work, because it also works in other IDEs such as Visual Studio Code used by my colleges.

marksweb commented 3 years ago

@jrief yes I've switched to project specific settings and it's picked it up nicely. Should be able to complete this release prep tonight.

jrief commented 3 years ago

As far as I have seen, this pull request just replaces formatting such as '{x}'.format(x=9) against f'{x}'. This means that Python-3.6 now is a minimum requirement.

marksweb commented 3 years ago

That's right @jrief

I looked over it & <3.5 appeared to have been removed so that became part of my checks for dropping old compatibility allowances 👍