search

jrief / django-admin-sortable2

Generic drag-and-drop ordering for objects in the Django admin interface
https://django-admin-sortable2.readthedocs.io/en/latest/
Other
753 stars 179 forks source link

1.0.1 - CSS error causing empty-rows to show #285

Closed nc-Brandon closed 2 years ago

nc-Brandon commented 3 years ago

This line in sortable.css:

div.inline-group table.ui-sortable tr.form-row {
    display: table-row;
}

Is overruling this line in forms.css from django admin:

.empty-form {
    display: none;
}

It is causing empty rows on inlines to show, heavily confusing users.

marksweb commented 2 years ago

@nc-Swift Did 1.0.2 fix this?

nc-Brandon commented 2 years ago

It looks like it did, yes. I had overriden admin/css/form.css to have:

.empty-form { display: none !important; }

I was able to remove that, and it seems like the rule isn't being overruled by sortable.css anymore.