search

jrief / django-admin-sortable2

Generic drag-and-drop ordering for objects in the Django admin interface
https://django-admin-sortable2.readthedocs.io/en/latest/
Other
770 stars 180 forks source link

small typo + latest docs are not deployed? #379

Closed gregsadetsky closed 1 year ago

gregsadetsky commented 1 year ago

on https://django-admin-sortable2.readthedocs.io/en/latest/usage.html , right above the "do not make this field unique!" warning, there is the following sentence:

"In addition to the reccomended fields, DecimalField or FloatField may work, but haven’t been testest." (sic)

"reccomended" should be "recommended" and "testest" should be "tested"

interestingly, in the source code, the first typo ("reccomended") has been fixed, but "testest" has not: see this line.

so -- the second typo should still be fixed... and the latest documentation should be deployed to readthedocs?

cheers!

gregsadetsky commented 1 year ago

another typo: "ineriting" on the same page, under "In Django's Admin, make the List View sortable"

that appears on this line

gregsadetsky commented 1 year ago

Hey @jrief thanks for taking care of this!

Small note that on this line, you corrected the word to be "inserting", but it should have been "inheriting" i.e.:

"By inserting inheriting from this mixin class together with django.contrib.admin.ModelAdmin, we get a list view which..."

Cheers