Get examples working with 1.8

jrief / django-angular

Let AngularJS play well with Django

http://django-angular.awesto.com/

MIT License

1.23k stars 293 forks source link

Get examples working with 1.8 #164

Closed AntonOfTheWoods closed 9 years ago

AntonOfTheWoods commented 9 years ago

Hi,

Django 1.8 has updated a few of it's methods that seem to be overridden in django-angular - by adding the optional method parameters to the methods (and adding an explicit init) we mirror the new django methods and are no longer failing. I would be very surprised if this broke anything but I suspect there will be a few more such cases before full compatibility with 1.8 can be declared.

jrief commented 9 years ago

Oh thanks, great work! Wouldn't you like to add Django-1.8 to the testing matrix in travis-ci.yml? We then could see, if unit tests pass on Travis.

AntonOfTheWoods commented 9 years ago

Hi Jacob, Sorry, I am a complete n00b when it comes to Travis. I am pretty sure I have added the right value and it should be passing - looking at the errors it looks like the build system had a network issue but I can't see how to force them to rerun the builds again. Can you do that?

AntonOfTheWoods commented 9 years ago

Ok, so it was indeed just a Travis network issue - everything is green now :-).

papasax commented 9 years ago

Yes!

2015-05-05 11:48 GMT+02:00 Jacob Rief notifications@github.com:

Merged #164 https://github.com/jrief/django-angular/pull/164.

— Reply to this email directly or view it on GitHub https://github.com/jrief/django-angular/pull/164#event-297049756.