search

jrief / django-angular

Let AngularJS play well with Django
http://django-angular.awesto.com/
MIT License
1.23k stars 294 forks source link

Feature/parametrized urls #255

Closed jkosir closed 8 years ago

jkosir commented 8 years ago

Solves #254, now we can use djangoUrl.reverse() to build parametrized templates for use with $resource.

Docs and tests are done. The only downside to this is that you can't have string args or kwarg values starting with :. I don't see any reason someone would use this in the first place, so it shouldn't be a problem.

jkosir commented 8 years ago

So any comments on this? @jrief @adrienbrunet

I'd merge it, but the docs will also update, so it would be good to release new version shortly after merging.

jrief commented 8 years ago

sorry, I never used/required parametrized URLs, but from my point of view it makes sense. So please feel free to merge it.

adrienbrunet commented 8 years ago

I had a look, it's nice. We were lacking such feature but I seldom need it. Feel free to merge it ! Great work, as always!