search

jrief / django-angular

Let AngularJS play well with Django
http://django-angular.awesto.com/
MIT License
1.23k stars 294 forks source link

Attempt to use transitional MiddlewareMixin if present #265

Closed jbittel closed 8 years ago

jbittel commented 8 years ago

Fixes a startup error when using the Django 1.10 MIDDLEWARE setting.

jkosir commented 8 years ago

Thanks for the PR! :+1:

So that's enough to make it work with 1.10? Haven't had time to try it yet.

jbittel commented 8 years ago

I just started testing it this morning, and that's the only thing I've run into so far to get it up and running. A number of the tests fail under 1.10, but at first glance it appears many of the failures have to do with how the test suite is calling the middleware directly. I've only had a few minutes to poke at the tests directly though.

It's also worth noting that the above fix is necessary if using the new MIDDLEWARE setting. Under the now deprecated MIDDLEWARE_CLASSES setting, it works without any changes.

Thanks!

jkosir commented 8 years ago

We aren't yet supporting 1.10, apparently some fixes will be needed for that.

As this doesn't break anything I'll go ahead and merge it anyway.