search

jrief / django-angular

Let AngularJS play well with Django
http://django-angular.awesto.com/
MIT License
1.23k stars 294 forks source link

Bootstrap4 #274

Closed adrienbrunet closed 7 years ago

adrienbrunet commented 7 years ago

Needs some more heavy testing before merge. I seldom make use of bootstrap4.

I've added a note in the docs to announce support for bootstrap4. All bootstrap3 mixins now have an equivalent for bootstrap4.

Bootstrap common code has been refactored in a bootstrap module inside djng/styling

A page to ease bootstrap4 testing has been added in examples. (Same layout than other subscribe forms)

adrienbrunet commented 7 years ago

@elcone Any feedback is welcome =)

elcone commented 7 years ago

thank's @adrienbrunet I'll test it and leave you my comments \m/

adrienbrunet commented 7 years ago

@elcone Did you have the chance to test it? All good? Ready for merge?

adrienbrunet commented 7 years ago

@elcone ? :smile:

adrienbrunet commented 7 years ago

@jrief should we merge it now or nobody seems interested enough and we'll wait a bit more?

jrief commented 7 years ago

With the next release of django-angular and Django-1.11 there is no more need to use the styling/bootstrap/whatever.py submodules, since it is enough to create an alternative template.

I'm sorry, if that pull request remains unmerged, but the new widget rendering functions are much more flexible and easier to override for alternative CSS frameworks.

adrienbrunet commented 7 years ago

No worries ! I'm closing this then !