search

jrief / django-angular

Let AngularJS play well with Django
http://django-angular.awesto.com/
MIT License
1.23k stars 293 forks source link

MRO issue for NgWidgetMixin, Select #312

Closed jameschristopher closed 7 years ago

jameschristopher commented 7 years ago

Has anyone else experience an MRO TypeError when using Select widgets ( for django ModelChoiceField) with NgModelForm, and NgModelFormMixin?

This issue seems to have been introduced during https://github.com/jrief/django-angular/commit/0376e8bf5ff438853c8617ffbf625af01c251211 as I do not get an exception when on version 1.0.0.

I'm not to familiar with the code there but would be willing to try and fix with a PR, this exception could also be an implementation error on my part.

jrief commented 7 years ago

Yes there is an issue already and will be fixed soon (give me 2 more weeks), or try yourself.

jameschristopher commented 7 years ago

Which issue? With a little more context I'll give it a try

asnoeyink commented 7 years ago

I have a PR which (should) fix this: #308. @jrief, is there something about that fix you don't like?

I'm not entirely sure what is causing the underlying issue, as I don't think most forms are rendered twice like my test case does in order to cause the error. Maybe that is what he is looking into.

jameschristopher commented 7 years ago

Oh, somehow I missed your PR. I'll close this issue then.