jrief / django-shop

A Django based shop system
http://www.django-shop.org
BSD 3-Clause "New" or "Revised" License
32 stars 12 forks source link

Hard dependencies #37

Closed rfleschenberg closed 8 years ago

rfleschenberg commented 8 years ago

I am creating this issue as a place to discuss how django-shop should specify its hard (non-optional) dependencies.

My suggestion:

  1. Follow established Python practice and specify them in setup.py with their minimum versions.
  2. Possibly document that we recommend to freeze them with exact versions in a project-wide requirements file.

Hard dependencies that I found so far:

vivazzi commented 8 years ago

+

rfleschenberg commented 8 years ago

Also:

jrief commented 8 years ago

I agree with django-select2, but django-angular should not be considered a hard dependency.

Well, I have to admit that all Javascript code, some template code and some Cascade plugins require AngularJS, thus django-angular makes perfectly sense as a dependency, but my intention is, to have that part pluggable in case someone want to use Ember, React or any other JS framework.

rfleschenberg commented 8 years ago

I agree that django-angular should not be a hard dependency (in general, the fewer dependencies, the better). But at the moment it is imported in shop/forms/checkout.py, shop/forms/auth.py and shop/forms/base.py. I did not really look at this code yet. Jacob, do you think it would be easily possible to eliminate the dependency or make it optional?

rfleschenberg commented 8 years ago

Closing here. Copied to https://github.com/awesto/django-shop/issues/313.

rfleschenberg commented 8 years ago

This issue was moved to awesto/django-shop#315