Improvements in javascript API.

jrief / django-websocket-redis

Websockets for Django applications using Redis as message queue

http://django-websocket-redis.awesto.com/

MIT License

896 stars 222 forks source link

Improvements in javascript API. #181

Closed yguarata closed 8 years ago

yguarata commented 8 years ago

Some improvements to the javascript API:

Trying to reconnect when the first attempt (on instantiation) fails.
Adding 'connecting' and 'disconnected' callback options.
Adding the 'close' method to the API. When the websocket is closed through this method, there will be no reconnection attempts.
Adding the following methods to the API to check websocket status: is_connecting, is_connected, is_closing, is_closed.

The documentation was also updated to reflect the changes.

jrief commented 8 years ago

why is speed important here? I personally don't like the prototype programming pattern and try to avoid it whenever I can.

yguarata commented 8 years ago

Well, actually it was really a weak argument for using prototype in this context. I'm refactoring the changes to the original programming standard. Sorry for that :(

yguarata commented 8 years ago

I did the changes to avoid the prototype programming pattern. I did not know that pull requests are automatically updated with new commits, so a reopened it. Please, take a look again in the proposed changes.

jrief commented 8 years ago

Great, I'll merge it. Please add a few lines to the changelog and explain to the rest of us, what your changes do. Thanks

yguarata commented 8 years ago

Done. Please, see if it is ok.

jrief commented 8 years ago

@nanuxbe could you please peer review this PR, before I release 0.4.7. Thanks