jrief / django-websocket-redis

Websockets for Django applications using Redis as message queue
http://django-websocket-redis.awesto.com/
MIT License
896 stars 222 forks source link

Adding support to cross domains. #185

Open yguarata opened 8 years ago

yguarata commented 8 years ago

It was added the setting WEBSOCKET_HOST. This enables using websockets in cross domains. This is, the websocket domain (e.g. ws.myapp.com) is different from the site domain (e.g. www.myapp.com). However, it is mandatory to provide the Django setting SESSION_COOKIE_DOMAIN (e.g. SESSION_COOKIE_DOMAIN = '.myapp.com'). This pull request is backwards compatible. Documentation and changelog were updated accordingly.

jrief commented 7 years ago

please rebase your pull request

yguarata commented 7 years ago

Pull request rebased.

yguarata commented 7 years ago

Closing this pull request because it is a little bit out of sync. I will perform some tests before opening another pull request.

yguarata commented 7 years ago

I've tested it with Django 1.8.18 and 1.11.3. Did I miss anything?