search

jrief / django-websocket-redis

Websockets for Django applications using Redis as message queue
http://django-websocket-redis.awesto.com/
MIT License
895 stars 221 forks source link

Handle ssl connections #284

Open gtnx opened 5 years ago

gtnx commented 5 years ago

As far as i understand, it looks impossible to use this library with SSL redis connections.

The reason is that settings.WS4REDIS_CONNECTION is used to instantiate:

The reason is that those two objects does not have the same signature for handling ssl connections:

I propose to use one of the two conventions (the ssl flag for instance which is easier to understand) and adapt code in wsgi_server.py.

What do you think?

jrief commented 5 years ago

from my point of view, I never saw the need to connect Redis through SSL, since it typically runs on the same host as the application server. How is your use-case / architecture?

gtnx commented 5 years ago

In our usecase, we use a managed Redis on Azure platform. By default Azure, only opens the 6380 port (dedicated to SSL connections. We don't want to use non-ssl port (6379) as we don't have a private network in this usecase.

jrief commented 5 years ago

OK. This is a really valid use-case. I would have to dig into this topic. Do you have time to create a pull-request?

gtnx commented 5 years ago

Yes i'll do it today