jrief / django-websocket-redis

Websockets for Django applications using Redis as message queue
http://django-websocket-redis.awesto.com/
MIT License
895 stars 222 forks source link

Issue #284 Handle ssl connections #285

Closed gtnx closed 1 year ago

gtnx commented 5 years ago

Btw, i've used black for the small parts i've changed. Have you considered using this tool. It really reduces time spent on code formatting and let developers focus on what matters.

In terms of testing, afaik travis does not support natively ssl redis-servers. Since modifications relies on well-tested code (redis.SSLConnection), i guess it's ok not to test it thoroughly.

gtnx commented 5 years ago

Hello,

What do you think about this?

grevzi commented 2 years ago

Hello @jrief. Could you check this PR, please? Is this ready to be merged?

mlindemu commented 1 year ago

Hello @jrief, love the library! I'm in the same boat as @gtnx (see: https://github.com/jrief/django-websocket-redis/issues/284). Need to use SSL in an Azure environment. Can you review this PR?

jrief commented 1 year ago

@gtnx would you like to take the maintenance of this library?