jrief / django-websocket-redis

Websockets for Django applications using Redis as message queue
http://django-websocket-redis.awesto.com/
MIT License
895 stars 221 forks source link

Add Django 2.1.5 and latest support. #288

Closed DaniilSezonov closed 5 years ago

DaniilSezonov commented 5 years ago

Close issue #286.

gtnx commented 5 years ago

Looks good. @jrief I see that last merged PR was almost one year ago. Have you considered integrating other maintainers?

jrief commented 5 years ago

Have you considered integrating other maintainers?

Yes, but noone asked until now. Would you like to become one?

gtnx commented 5 years ago

Yes. I use this package in production in my company for almost 4 years now. I'm not super familiar with this package codebase but i can totally support you on those kind of tickets which are important for the community.

gtnx commented 5 years ago

@DaniilSezonov Could you add the 2.1.5 to the ci matrix. IT's in travis.yml in the env section? Thanks

jrief commented 5 years ago

btw., what's your username on PyPI?

DaniilSezonov commented 5 years ago

Something was wrong, sorry, I have no experience with CI/CD configuration.

DaniilSezonov commented 5 years ago

Trying again

gtnx commented 5 years ago

@jrief this is guillaume.thomas

gtnx commented 5 years ago

As i said it looks good. I tested it using a personal project and not the example project which still needs to be compatible with latest django versions (See #246).

gtnx commented 5 years ago

@jrief Could you add me as well on pypi? Thanks