search

jrief / djangocms-cascade

Build Single Page Applications using the Django-CMS plugin system
MIT License
165 stars 85 forks source link

Subject location on picture plugins not honored #328

Closed darbula closed 5 years ago

darbula commented 5 years ago

The problem is probably with these lines for bootstrap3 and these for bootstrap4 since subject_location ends up being either None or bool and not being None or str (subject location data) as intended. The solution might be something like this:

    if hasattr(instance.image, 'subject_location') and 'subject_location' in resize_options:
        subject_location = instance.image.subject_location
    else:
        subject_location = None
jrief commented 5 years ago

I will check this, as soon as I have some time.

jrief commented 5 years ago

Please recheck with current version on GitHub. I then will release 0.18.1. Thanks for reporting.