search

jrief / djangocms-cascade

Build Single Page Applications using the Django-CMS plugin system
MIT License
165 stars 85 forks source link

Invalid tags of an image after rendering TextImagePlugin #397

Closed execut closed 3 years ago

execut commented 3 years ago

For example we has image for TextImagePlugin with attributes:

image_title: title value
alt_tag: alt value

result html:

<img tag="alt value" ...>

expected result:

<img alt="alt value" title="title value" ...>

I think alt doesn't work correctly because of a typo here: https://github.com/jrief/djangocms-cascade/blob/dec776711185d0d7de76b0ca30d984732dc88d0f/cmsplugin_cascade/generic/text_image.py#L66

Title does not work due to the fact that here it is reassigned from the parent class: https://github.com/jrief/djangocms-cascade/blob/dec776711185d0d7de76b0ca30d984732dc88d0f/cmsplugin_cascade/generic/text_image.py#L67

jrief commented 3 years ago

close via #398