jrincayc / ucblogo-code

Berkeley Logo interpreter
https://people.eecs.berkeley.edu/~bh/logo.html
GNU General Public License v3.0
182 stars 34 forks source link

Configure wxWidgets OSX build to avoid linking to brew installed regex library #164

Closed dmalec closed 1 year ago

dmalec commented 1 year ago

Adds --with-regex=builtin to CD build for wxWidgets on OSX to prevent dynamic linking to the homebrew installed library on the GitHub action runners. Similar to issue #158 and #161

Test Environments

jrincayc commented 1 year ago

Thanks, and let me know if you think we should make a new release in the near future.

brianharvey commented 1 year ago

I vote yes for a new release; last time I downloaded the MacOS version it wouldn't run.

jrincayc commented 1 year ago

Can you check that the newest generated MacOS version runs for you: https://github.com/jrincayc/ucblogo-code/suites/11775835829/artifacts/614095497 ? Thanks

dmalec commented 1 year ago

Thanks for bearing with me as I sort out the unintended dependencies that were introduced by the runner environments, I know it's caused churn for folks.

I also like the idea of a new release in the near future - I think we should now be stable on OSX; but, I'm game to run any tests folks can think of.

jrincayc commented 1 year ago

Yes, if we can get an automatically generated mac version that works for both @brianharvey and @dmalec computers, I think we should make a new release :)

dmalec commented 1 year ago

The linked build works for me on two macs:

  1. OSX 10.15.7 on Intel Core i7 - primary dev machine so it has various homebrew installed libraries
  2. OSX 13.2.1 on Apple M2 - mostly stock machine, has XCode and built from source versions of autoconf, automake, & m4 (to try and avoid false positives due to homebrew)
brianharvey commented 1 year ago

Josh, your link 404s for me.

jrincayc commented 1 year ago

ucblogo.dmg(4).zip Hm, here it is as an upload.

brianharvey commented 1 year ago

Yay! It works. Thanks!