search

jrincayc / ucblogo-code

Berkeley Logo interpreter
https://people.eecs.berkeley.edu/~bh/logo.html
GNU General Public License v3.0
190 stars 34 forks source link

Don't handle control and alt commands in terminal. #175

Closed jrincayc closed 10 months ago

jrincayc commented 11 months ago

These need to be handled by wxMenuBar.

Closes #172

jrincayc commented 11 months ago

For what it is worth, ChatGPT suggested using event.Skip() and otherwise assisted in this.

jrincayc commented 11 months ago

I am kind of wondering if there are any times when things with Control or Alt are pressed that should be handled by wxTerminal::OnChar (there is the following code:

    if (event.ControlDown()) keyCode &= 0237;
    if (event.AltDown()) keyCode += 0200;

that is trying to handle those keys.)

jrincayc commented 11 months ago

Ctrl-M is no-longer gives a return. Ctrl-C and Ctrl-V do copy and paste.

@brianharvey I am trying to decided if I am blocking any input that should still be handled in the text editor with this pull request (Ctrl-M seems to be the only one that this blocks). Thanks