jrincayc / ucblogo-code

Berkeley Logo interpreter
https://people.eecs.berkeley.edu/~bh/logo.html
GNU General Public License v3.0
187 stars 34 forks source link

CD workflow - build (but do not release) release candidate artifacts. #81

Closed dmalec closed 3 years ago

dmalec commented 3 years ago

To set some context- I'm submitting this PR with the thought it may assist in the overall 6.2 release process. If it's more of a disruption at this point, I can close the PR and work on this as a post-6.2 idea (no worries either way :) ).

I've tried to break down the change into three rough categories below; but, am also going to add a few comments in places where I'm particularly uncertain about the changes I made. To get a sense of what it looks like in action: https://github.com/dmalec/ucblogo-code/actions/runs/430995787

(You can view the workflow anonymously; but, do need to be logged into GitHub to download the artifacts)

CD features:

CD motivated changes:

6.2 specific changes:

jrincayc commented 3 years ago

Thanks, that looks useful, I'll review it more later.

dmalec commented 3 years ago

I think I'm closing in on the next revision - hoping to have an update by end of day.

dmalec commented 3 years ago

As long as the changes I've made in makefile.msys don't disrupt local builds, I think this is "there" from a GitHub runner machine perspective.

jrincayc commented 3 years ago

Is this ready for merge?

dmalec commented 3 years ago

Is this ready for merge?

@jrincayc - yes, this is ready for merge.