search

jrit / web-resource-inliner

Inlines img, script and link tags into the same file
MIT License
69 stars 30 forks source link

Would it be possible to have the dependency upgrades under a major version change? #48

Closed ghost closed 4 years ago

ghost commented 5 years ago

Hey,

This library is a dependency on the library, Juice and it's on the package.json as:

"web-resource-inliner": "^4.3.1"

Due to that, the dependency upgrade of this library with the patch release 4.3.2 effectively made Juice incompatible with node v4.3 even though Juice still lists support on its package.json.

Since the project I'm working on is one of those dinosaurs that's still stuck on node v4.3, would it be possible to increment this library to v5 instead of 4.3.2 to denote breaking changes? Otherwise, the newest version of Juice that truly supports node v4.3 would be version 3.0.1, which was released 3 years ago.

Please let me know if I can provide a PR or if it would be more appropriate to bring this up as an issue on Juice's repository -- the change to "web-resource-inliner": "~4.3.1" would resolve my issue as well.

jrit commented 5 years ago

I think what I'll do, since I maintain Juice too, is make a patch on juice as 5.2.1 that uses web-resource-inliner at 4.3.2 specifically. That will be the last release of juice that supports node 4. Then I'll release juice 6.0.0 that will drop support for node 4 and uses the latest web-resource-inliner. I may not get to this today, but that's my plan. I think that is the proper way to semver this, but I'm open to suggestions.

ghost commented 5 years ago

That sounds perfect; thanks for looking into this!

On Jul 19, 2019, at 10:18, Jarrett Widman notifications@github.com wrote:

I think what I'll do, since I maintain Juice too, is make a patch on juice as 5.2.1 that uses web-resource-inliner at 4.3.2 specifically. That will be the last release of juice that supports node 4. Then I'll release juice 6.0.0 that will drop support for node 4 and uses the latest web-resource-inliner. I may not get to this today, but that's my plan. I think that is the proper way to semver this, but I'm open to suggestions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

jrit commented 4 years ago

There is a juice 5.1.9 on npm that uses wri 4.3.2 now. sorry, this is months overdue and I'm sure it was an inconvenience