breaking: require Node.js v10

jrit / web-resource-inliner

Inlines img, script and link tags into the same file

MIT License

66 stars 29 forks source link

breaking: require Node.js v10 #55

Closed TrySound closed 4 years ago

TrySound commented 4 years ago

replaced xtend with Object.assign

jrit commented 4 years ago

I believe testing node will always use the latest. I understand adding older versions for backwards compatibility, but do you have a reason for removing the shortcut for the latest version? Or a reason for removing 6 and 8? Is this fixing something that is worth breaking 6 and 8 for?

Sorry about the delayed reply, something is wrong with my github notifications apparently

TrySound commented 4 years ago

Reverted "node". Latest chalk version supports only node v10. All other versions are eol already. https://nodejs.org/en/about/releases/

TrySound commented 4 years ago

Replacing "request" will anyway be a breaking change btw.