Refactor async parallel with Promise.all

jrit / web-resource-inliner

Inlines img, script and link tags into the same file

MIT License

66 stars 29 forks source link

Refactor async parallel with Promise.all #59

Closed TrySound closed 4 years ago

TrySound commented 4 years ago

Ref https://github.com/jrit/web-resource-inliner/issues/58

In this diff I refactored as small as possible part of code to replace async.parallel with Promise.all and do not introduce any breaking changes.

Further refactoring can be made in separate PR.

TrySound commented 4 years ago

cc @jrit

TrySound commented 4 years ago

My interest here is mjml which depends on juice so I will try to simplify juice as well after finishing with this package.

jrit commented 4 years ago

can you resolve the conflicts on this one? I think I can merge and release on this PR without anything breaking before merging the one that requires node 10 and will be a major version. Correct?

TrySound commented 4 years ago

Right, done.