Open GoogleCodeExporter opened 9 years ago
Thanks for reporting these problems. I'm in no way a GTK2 expert or a user
interface designer by heart. So your participation and reasoning is most
welcome :)
If anyone want to add any suggestions that are also related to user interface
improvements, please post them to this thread.
Original comment by rubyripp...@gmail.com
on 24 Jan 2008 at 8:37
Keyboard accelerators for the common buttons would be nice. 'P' for
Preferences, 'S'
for Scan drive etc. ctrl-Q should quit.
Original comment by hha...@gmail.com
on 8 Feb 2008 at 8:34
A button to cancel the ripping process would be nice. ATM one can only exit the
whole program. In addition after ripping the 'Open tray' button should turn
into
'Close tray' when the disc was ejected. I already tried my hands on these but
didn't
get far due to lack of time.
Very nice app btw!
Original comment by j...@rapidrabbit.de
on 20 May 2008 at 10:49
Here's a patch to fix the eject button. Basic stuff, not even worth a patch
actually, but maybe it helps.
Original comment by j...@rapidrabbit.de
on 20 May 2008 at 4:16
Attachments:
Another patch attached. This one turns the 'Exit' button into a 'Cancel' button
during the ripping process. It switches back when the ripping is done or in
case of
error. Could be refined I guess, but it does the job. Only problem is, that it
throws some gettext error:
/usr/lib/ruby/site_ruby/1.8/gettext.rb: line 229
Gtk-CRITICAL **:gtk_text_layout_get_iter_location: assertion `GTK_IS_TEXT_LAYOUT
(layout)' failed
I guess the translations would need to be updated for this to work properly.
Let me know if this is helpful.
Original comment by j...@rapidrabbit.de
on 20 May 2008 at 5:10
Attachments:
Forgot to mention, it's rubyripper 0.5.0 I'm patching for.
Original comment by j...@rapidrabbit.de
on 20 May 2008 at 5:12
Thanks for sending patches :) I'll try to merge them when I've some time.
You can try ./configure --update-lang and see if it solves the gettext error.
Original comment by rubyripp...@gmail.com
on 20 May 2008 at 5:23
[deleted comment]
No problem. I need to learn some Ruby for my work anyway. :)
Unfortunately I don't seem to get around that gettext problem. The error
message
only disappears when I don't touch the label text of the 'Exit' button. I
surely
overlooked something.
BTW: I just recognized that the .rb files in the source archive have different
names
than the ones on my filesystem which I used to create the patches. So you might
need
to change the filenames in the patch files.
Original comment by j...@rapidrabbit.de
on 20 May 2008 at 8:17
The eject-button thing is merged in svn r288.
Original comment by rubyripp...@gmail.com
on 6 Aug 2008 at 12:55
The summary page now shows the artist and album info in svn r289.
Original comment by rubyripp...@gmail.com
on 6 Aug 2008 at 1:15
Disc info page now fuly allocates space for album and artist since r290.
Original comment by rubyripp...@gmail.com
on 6 Aug 2008 at 1:36
Added accelerator keys for the main buttons in r291. The shortcuts will depend
on
your language. Normally ALT + the_underscored_letter.
Original comment by rubyripp...@gmail.com
on 6 Aug 2008 at 2:38
One other enhancement - at present I know know way to tell what version of Ruby
is running within the GUI (I
had multiple versions installed at one point and was trying to see about this.)
Usually there is an "About . . ."
option in the menus which shows this. Just a suggestion, obviously not a big
deal.
Original comment by Jer....@gmail.com
on 29 Jan 2009 at 10:42
You did notice that the rubyripper version is always mentioned it the log files?
Original comment by rubyripp...@gmail.com
on 31 Jan 2009 at 7:45
Aha. Did not notice. Thanks for the info!
Original comment by Jer....@gmail.com
on 5 Feb 2009 at 7:52
Fixed the 1st issue with commit (well, sort of):
http://github.com/rubyripperdev/rubyripper/commit/7979e7f0095913ca1d380a452e612a
4b0657
273a
That means only 4th and 5th point are still open?
Original comment by boukewou...@gmail.com
on 26 Apr 2010 at 8:24
Original issue reported on code.google.com by
dj.gg...@johannis.net
on 24 Jan 2008 at 8:09