jrittenh / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Crash before last track rips #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Rip CD

What is the expected output? What do you see instead?
should start last track but instead bombs

What version of the product are you using? On what operating system?
svn 19, debian

Please provide any additional information below.
outputting to /Files/rr/track8_2.wav

 (== PROGRESS == [                              | 146841 00 ] == :^D * ==)

Done.

./rr_lib.rb:343:in `initialize': undefined method `include?' for
false:FalseClass (NoMethodError)
        from ./rr_lib.rb:722:in `new'
        from ./rr_lib.rb:722:in `ripper'
        from ./rr_lib.rb:721:in `each'
        from ./rr_lib.rb:721:in `ripper'
        from ./rr_lib.rb:598:in `initialize'
        from ./rubyripper_gtk2.rb:147:in `new'
        from ./rubyripper_gtk2.rb:147:in `on_ripcdbutton_clicked'
        from ./rubyripper_gtk2.rb:140:in `initialize'
        from ./rubyripper_gtk2.rb:140:in `new'
        from ./rubyripper_gtk2.rb:140:in `on_ripcdbutton_clicked'
        from ./rubyripper_gtk2.rb:8:in `to_proc'
        from ./rubyripper_gtk2.rb:355:in `call'
        from ./rubyripper_gtk2.rb:355:in `main'
        from ./rubyripper_gtk2.rb:355

Original issue reported on code.google.com by mordbr...@gmail.com on 19 Nov 2006 at 10:03

GoogleCodeExporter commented 9 years ago
Bug found and solved. It won't happen if you have any cdparanoia parameters. 
But 
otherwise not a string is passed, but just a boolean (false). Therefore it 
errors 
out.

As I'm in the middle of fighting the summary bug, I won't update the svn code 
immediately. However, you can easily add in rr_lib.rb, line 343, after ('-Z')

' if @settings['rippersettings']' (without the outside quotes)

This first tests if it isn't false. (A string compares to true).

Original comment by rubyripp...@gmail.com on 19 Nov 2006 at 10:48