jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
153 stars 98 forks source link

`scipy.misc.imresize` removed from version 1.3.0 of SciPy. #187

Closed Matthew-Jennings closed 5 years ago

Matthew-Jennings commented 5 years ago

Describe the bug pylinac.core.image uses imresize from scipy.misc, but scipy.misc.imresize has been removed from SciPy as of version 1.3.0.

A straight pip install pylinac will now pull scipy==1.3.0, which is now incompatible with sections of pylinac that use any of the (now removed) functions listed here.

Proposed solution Consider replacing scipy.misc.imresize with skimage.transform.resize as per the scipy docs, and similarly for any other uses of functions not present in version 1.3.0 of SciPy. Or pin to scipy<=1.2.1?

jrkerns commented 5 years ago

Good catch, thanks.

Matthew-Jennings commented 5 years ago

No worries :)

bozhikovstanislav commented 5 years ago

Is someone have any idea where this module is placed ?

randlet commented 5 years ago

According to the docs it was removed completely: https://docs.scipy.org/doc/scipy-1.2.1/reference/generated/scipy.misc.imresize.html

However they give an alternative using Pillow directly.

Randy

On Thu., Jul. 18, 2019, 5:32 a.m. Stanislav Bozhikov, < notifications@github.com> wrote:

Is someone have any idea where this module is placed ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jrkerns/pylinac/issues/187?email_source=notifications&email_token=AAATCMGLNH4ECULCQJYDYHDQAA2BPA5CNFSM4HN5WTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2H44PQ#issuecomment-512740926, or mute the thread https://github.com/notifications/unsubscribe-auth/AAATCMBWXFE4VKPUFO4R7BTQAA2BPANCNFSM4HN5WTRA .