jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
158 stars 99 forks source link

VMAT module passing criteria error #266

Closed brjdenis closed 4 years ago

brjdenis commented 5 years ago

Hi!

The VMAT module does not properly detect failed segments if the r_dev is negative. Line 423, I think, is the problem because no absolute value is used:

return self.r_dev < self._tolerance * 100

If you set the tolerance at 1 % and if r_dev for a particular segment is, say, -1.1 %, the segment will still have a passing status.

Best regards, Denis

jrkerns commented 4 years ago

Verified. Good catch.