jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
153 stars 98 forks source link

Make catphan analysis extensible #286

Closed jrkerns closed 4 years ago

jrkerns commented 4 years ago

The user should be able to 1) specify the modules they would like to analyze and 2) override individual module settings. 1) is already done. The user can overload the modules attr to modify the offset and add/remove individual modules. 2) is not doable right now because each catphan expects the exact module (rather than a subclass). Users would have to edit the library in place to achieve this.

This should be solvable by creating a method to get/check the modules attr for not exact classes, but subclasses of the modules. The user can then place their own subclassed modules in the modules attr of the catphan class to achieve an overload.

jrkerns commented 4 years ago

Closed in https://github.com/jrkerns/pylinac/commit/5785f6814e8561871d975843a9d5e0c65d322c6d