search

jrkerns / pylinac

An image analysis library for medical physics
https://pylinac.readthedocs.io/en/latest/
MIT License
152 stars 95 forks source link

Profile parameter calculator #296

Open crcrewso opened 4 years ago

crcrewso commented 4 years ago

Is your feature request related to a problem? Please describe. No issues - Functionality extension

Describe the solution you'd like

Describe alternatives you've considered

Additional context

If the project maintainers feel this is of value please assign me.

jrkerns commented 4 years ago

I wrote a file parser example here a little while ago. I think it would indeed be pretty useful to have such a parser. Feel free to make a pull request against pylinac. You are also free to do it on your own if you'd like. I'm a slow dinosaur and it takes me a while to get changes out so if you want it asap then probably release on your own, otherwise I'm happy to review and work on this. The good news is this should be a pretty basic implementation.

crcrewso commented 4 years ago

I can see what you're doing there. It's a great start! My first guess for a layout is:

Does this make sense? Would you rather a different organization method? If it does I'll work on getting the feature into a PR.

jrkerns commented 3 years ago

Partially closed in #361. The integration with flatsym will happen after integrating #331

crcrewso commented 3 years ago

For testing, what test cases would you like to see added? I can provide (or generate) a few on our IC Profiler for Unit Testing

jrkerns commented 3 years ago

That would be much appreciated. I have the typical data of open beams. IIRC there was a movie-like mode; I don't have any of that data. I also don't know if anything has changed in the firmware/file format since my data was taken (~2.5 years ago). Also in the file data it says a detector may be ignored. It's not clear if that's a user-directed thing, or something SNC does on the backend somewhere. If any of that rings a bell then that data would be appreciated to fill out the parser. Thanks!

crcrewso commented 3 years ago

I don't have movie mode or live mode, but, that's only really useful for beam alignment and the output of the first MU's

I'll get a dataset together with dose and array calibrations, flat fields, excluded detectors, etc. While I'm putting that data together would you like some PD's of asymmetric jaw fields? AAPM recommendation monthly test 8, CPQR ML14 or is this outside the scope of the flatness/symmetry module

jrkerns commented 3 years ago

Re movie mode: I agree, I just don't have that data. I'm not keen on adding it, but you asked =)

By PD do you mean EPID images? Asymmetric fields are not outside the scope of the flat/sym module and so such images are welcome. TBH I'd be more keen on asymmetric MLC fields since the penumbra will be different. Thus far I've used either the image generator module or Portal Dosimetry fluence generation but you can never beat the real thing. Alan did an overhaul of the flat/sym module with better interpolation for low density data (e.g. Profiler) but I haven't gotten to it yet (read: lazy). I haven't see how well it does for that low density data. After that, verifying asymmetric data would be a good idea.

On Wed, Apr 7, 2021 at 10:31 AM crcrewso @.***> wrote:

I don't have movie mode or live mode, but, that's only really useful for beam alignment and the output of the first MU's

I'll get a dataset together with dose and array calibrations, flat fields, excluded detectors, etc. While I'm putting that data together would you like some PD's of asymmetric jaw fields? AAPM recommendation https://aapm.onlinelibrary.wiley.com/doi/pdf/10.1002/acm2.12080 monthly test 8, CPQR ML14 https://dx.doi.org/10.1002%2Facm2.12236 or is this outside the scope of the flatness/symmetry module

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jrkerns/pylinac/issues/296#issuecomment-815009995, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEUWCEPCSKJHEBDFGNRQX3THR3EZANCNFSM4NGLBYGQ .

crcrewso commented 3 years ago

Yes, I did mean EPID. I'll see about grabbing the same asymmetric MLC and jaw fields on EPID and IC Profiler. We've retired our profiler2 so I won't be able to go back that far.