Describe the bug
In tests_basic/core/test_profile.py line 82 the field edge indices are given as (60, 140). If I look at a plot of the sawtooth function (attached) aren't the field edge indices (50, 150) or am I missing something? The reason I ask is because my new field edge algorithm returns (50, 150). I think the discrepancy is related to what I observed earlier in #332 (https://github.com/jrkerns/pylinac/pull/332#discussion_r581769083)
To Reproduce
In pylinac
1) git checkout master
2) python3 -m unittest tests_basic/core/test_profile.py
All tests pass.
3) git checkout fieldparams
4) python3 -m unittest tests_basic/core/test_profile.py
2 tests fail AssertionError: 60 != 50 within 0.1 delta (10 difference)
Hi
Describe the bug In tests_basic/core/test_profile.py line 82 the field edge indices are given as (60, 140). If I look at a plot of the sawtooth function (attached) aren't the field edge indices (50, 150) or am I missing something? The reason I ask is because my new field edge algorithm returns (50, 150). I think the discrepancy is related to what I observed earlier in #332 (https://github.com/jrkerns/pylinac/pull/332#discussion_r581769083)
To Reproduce In pylinac 1) git checkout master 2) python3 -m unittest tests_basic/core/test_profile.py All tests pass. 3) git checkout fieldparams 4) python3 -m unittest tests_basic/core/test_profile.py 2 tests fail AssertionError: 60 != 50 within 0.1 delta (10 difference)
Regards Alan